-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle pagination in ssm describeInstanceInformation & API Rate Limit #738
Open
ThaSami
wants to merge
5
commits into
litmuschaos:master
Choose a base branch
from
ThaSami:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Shabaneh <[email protected]>
neelanjan00
reviewed
Mar 18, 2025
Tagging @uditgaurav for a codeowner review. |
Signed-off-by: Sami Shabaneh <[email protected]>
Signed-off-by: Sami Shabaneh <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Sami Shabaneh <[email protected]>
Signed-off-by: Sami Shabaneh <[email protected]>
Thank you @ThaSami for this PR. Alot of other folks will benefit from this, I'm looking forward to it getting merged by the litmus maintainers soon 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where experiments running SSM by tag sometimes report misleading IAM permission errors. The root cause is twofold:
The implementation of DescribeInstanceInformation did not handle pagination properly. By default, the API returns limited results per page, so if target instances reside on subsequent pages, they won't be found in the first API response—resulting in erroneous permission error messages.
The code was not properly handling AWS API rate limits, causing failures during high-volume operations when throttling occurred.
The fix:
These changes ensure reliable operation even with large numbers of instances and during periods of high API load.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes #737
Special notes for your reviewer:
Checklist:
breaking-changes
tagrequires-upgrade
tag