-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat(adk): Implement Google ADK Session Backend #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the 'litestar db migrations downgrade' command to quickstart.rst to complete the CLI migration workflow documentation. This provides users with the full set of essential migration commands: - generate: Create new migrations - upgrade: Apply migrations - downgrade: Rollback migrations (NEW) Addresses completeness requirement from PR #101 verification.
Updated ADK examples to follow current API patterns and CLAUDE.md standards: **adk_basic_aiosqlite.py:** - Fixed Session object attribute access (session.id instead of session['id']) - Fixed delete_session() API to include required app_name and user_id parameters - Fixed ListSessionsResponse access (.sessions property) **adk_litestar_asyncpg.py:** - Moved uvicorn import to module level (CLAUDE.md compliance) - Removed nested import from main() function **Verified (no changes needed):** - adk_basic_asyncpg.py - Already compliant - adk_multi_tenant.py - Already compliant - adk_duckdb_user_fk.py - Already compliant (canonical owner_id_column example) All examples now: - Use correct owner_id_column naming (not deprecated user_fk_column) - Use Session object attributes correctly (.id, .app_name, .user_id) - Follow CLAUDE.md import standards (no nested imports) - Pass Python syntax validation - Follow current SQLSpecSessionService API See ADK_EXAMPLES_VERIFICATION_REPORT.md for detailed verification.
- Change section titles from marketing style to neutral - 'Production-Ready' -> 'Production Features' - 'Developer-Friendly' -> 'Development Features' - 'Performance Optimized' -> 'Performance Features' - Replace casual language with professional terminology - 'Blazing Fast' -> 'High Performance' - Maintain consistent, technical, helpful tone throughout These changes align documentation with professional technical writing standards while preserving clarity and usefulness.
- Remove duplicate examples (mysql, duckdb, bigquery, sqlite sync) - Keep asyncpg, aiosqlite, litestar integration, multi-tenant examples - Update all documentation cross-references to removed examples - Fix broken literalinclude and :doc: references - Exclude STYLE_GUIDE.md and VOICE_AUDIT_REPORT.md from Sphinx build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a Google ADK session backend extension for SQLSpec. This enhances the framework's capabilities for managing sessions and events in applications using the Google Agent Development Kit.