Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Findfmt.cmake like FindFeast.cmake. #92

Closed
wants to merge 1 commit into from

Conversation

iglesias
Copy link
Collaborator

@iglesias iglesias commented May 1, 2024

No description provided.

@iglesias iglesias self-assigned this May 1, 2024
@lisitsyn
Copy link
Owner

lisitsyn commented May 1, 2024

I am a bit confused. What is the platform you're fixing with custom Find Cmake?

@iglesias
Copy link
Collaborator Author

iglesias commented May 1, 2024

I am a bit confused. What is the platform you're fixing with custom Find Cmake?

Sorry for the noise, I overlooked and should have made it draft. It's not ready yet.

About the platform, this change came up while working on cygwin for the mingw issue. With this "it helps" providing a direct error message of fmt missing, but it does not work yet in the most important path when it is available :)

I am not 100% sure I will be pushing it again tomorrow already, but during this week for sure.

@iglesias iglesias marked this pull request as draft May 1, 2024 20:25
@lisitsyn
Copy link
Owner

lisitsyn commented May 1, 2024

Got it!

@iglesias
Copy link
Collaborator Author

iglesias commented May 1, 2024

Found the button now to change it to draft even after it's opened, didn't see it before so thought it wasn't possible. So, thanks for the message after all :-D

@iglesias
Copy link
Collaborator Author

iglesias commented May 5, 2024

Ah, what I tried here with cmake is looking for the library, whereas I think fmt is being used header-only. It can be kept as it was, the direct error message if fmt is missing is probably not worth. Sorry for the confusion.

@iglesias iglesias closed this May 5, 2024
@iglesias iglesias deleted the cmake/fmt branch May 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants