Skip to content

Commit

Permalink
Rename pimpl callbacks to virtual callbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
lisitsyn committed May 6, 2024
1 parent a7044a6 commit 1bd6790
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
// similarity function values on vectors
// given by their indices. This impl. computes
// kernel i.e. dot product between two vectors.
template <class Implementation> struct pimpl_kernel_callback
template <class Implementation> struct virtual_kernel_callback
{
pimpl_kernel_callback(Implementation* i) : impl(i){};
virtual_kernel_callback(Implementation* i) : impl(i){};
inline tapkee::ScalarType kernel(int a, int b) const
{
return impl->kernel(a, b);
Expand All @@ -26,9 +26,9 @@ template <class Implementation> struct pimpl_kernel_callback
// dissimilarity function values on vectors
// given by their indices. This impl. computes
// euclidean distance between two vectors.
template <class Implementation> struct pimpl_distance_callback
template <class Implementation> struct virtual_distance_callback
{
pimpl_distance_callback(Implementation* i) : impl(i){};
virtual_distance_callback(Implementation* i) : impl(i){};
inline tapkee::ScalarType distance(int a, int b) const
{
return impl->distance(a, b);
Expand Down

0 comments on commit 1bd6790

Please sign in to comment.