refactor: templates for standardise-validate and create-collection topo-imagery commands TDE-1346 #970
Conversation
amfage
requested review from
blacha,
schmidtnz,
MDavidson17 and
paulfouquet
and removed request for
MDavidson17
|
|
||
| container: | ||
| image: '019359803926.dkr.ecr.ap-southeast-2.amazonaws.com/topo-imagery:{{=sprig.trim(inputs.parameters.version_topo_imagery)}}' | ||
| args: |
There was a problem hiding this comment.
I think it is missing --capture-dates?
| - '{{=sprig.trim(inputs.parameters.historic_survey_number)}}' | ||
| - '--lifecycle' | ||
| - '{{=sprig.trim(inputs.parameters.lifecycle)}}' | ||
| - '--add-title-suffix' |
There was a problem hiding this comment.
This should be optional. For example, national DEM does not want the suffix in the title.
| spec: | ||
| templateDefaults: | ||
| container: | ||
| imagePullPolicy: Always |
There was a problem hiding this comment.
Not specific to this PR, as this is something we do in most (if not all) our yaml files.
I'm wondering why we specify the imagePullPolicy on templateDefaults level with empty string for image instead of setting the policy where the actual container / image gets set?
There was a problem hiding this comment.
In general, it is in the spec so it applies to all containers within a workflowtemplate.
In this instance, it's just there in case this workflowtemplate is run standalone and not called from another workflowtemplate.
Motivation
The standardise-validate and create-collection commands need to be used by multiple workflows, as we are now publishing multiple products such as a National DEM and National Hillshades.
Modification
Create separate WorkflowTemplates for
standardise-validateandcreate-collection.Update current WorkflowTemplates
national-demandimagery-standardisingthat use these templates.Checklist