fix(standardise-validate): allow empty string from Argo for start and end dates TDE-1346 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amfage
changed the title
paulfouquet
approved these changes
Feb 13, 2025
| @@ -71,3 +74,17 @@ def test_coalesce_nothing() -> None: | |||
| single_item = "" | |||
| coalesced_list = coalesce_multi_single(multi_items, single_item) | |||
| assert coalesced_list == [] | |||
|
|
|||
|
|
|||
| def test_valid_date_empty_string() -> None: | |||
There was a problem hiding this comment.
You can instead create doctests for this kind of unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Argo Workflows supplies single quotes for optional parameters, which are not valid dates. These are handled later in the
standardise_validate.pycode.Modifications
Allow an empty string to be accepted by the command line parser for the start and end dates.
Verification
Added unit tests. Tested from Argo Workflows using a PR container.