Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stac-setup): support historical survey names LI-3977 #1198

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(stac-setup): support historical survey names LI-3977 #1198

wants to merge 4 commits into from

Conversation

blacha
Copy link
Member

@blacha blacha commented Feb 13, 2025

Motivation

We are still receiving more historical imagery we need to ensure we can continue to process the historical imagery

Modification

Add survey id to the list of optional arguments for stac-setup so that slugs can include the historical survery eg

west-coast_otago_sn8321_1984-1985_0.375m
west-coast_sn8534_1985-1986_0.375m
west-coast_sn9641_1997_0.75m

Verification

Unit tests

@blacha blacha marked this pull request as ready for review February 13, 2025 03:09
@blacha blacha requested review from a team as code owners February 13, 2025 03:09
schmidtnz
schmidtnz reviewed Feb 13, 2025
View reviewed changes
src/commands/stac-setup/__test__/stac.setup.test.ts Outdated
assert.equal(formatDate(startYear, endYear), '2023-2024');
assert.equal(formatDate('2023', '2024'), '2023-2024');
});
it('Should only return a data if both are set', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/type-o (date not data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidtnz schmidtnz schmidtnz left review comments

@paulfouquet paulfouquet paulfouquet approved these changes

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

@tawera-manaena tawera-manaena Awaiting requested review from tawera-manaena tawera-manaena is a code owner automatically assigned from linz/proj-basemaps-dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blacha @schmidtnz @paulfouquet