-
Notifications
You must be signed in to change notification settings - Fork 172
[WIP] Feat/firmaware upgrade window #237 #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kacperpaczos
wants to merge
15
commits into
linuxmint:master
Choose a base branch
from
kacperpaczos:feat/firmaware-upgrade-window
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Feat/firmaware upgrade window #237 #966
kacperpaczos
wants to merge
15
commits into
linuxmint:master
from
kacperpaczos:feat/firmaware-upgrade-window
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xec, FeatureFlags type fix; UI empty state for releases; menu icon
…on; populate fields from Fwupd.Release
…stall duration, flashes left, lock status) and populate from Fwupd.Device
…) and progress bar; wire remotes fetch and progress updates
…DE), and post-install reboot/shutdown prompts
…S device-list upload; wire buttons in UI
…ls formatting; add device-list dialog and wire buttons
…list and flags text; minor UI polish
…ce-list upload (fallback to CLI); track LVFS remote and report metadata
…aligned layout (sizegroups next); improve UX messages
…els; add keypress handler
…lement install-from-file via get_details_async; extend status mapping
Fix #237 |
Hi, please don't include any locale or .pycache files (this PR should only have 3 files changed). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: WIP, ready for review. So far tested only in VirtualBox – I need help testing on real hardware (USB, Thunderbolt, NVMe/SSD, devices with Secure Boot/TPM, reboot/shutdown scenarios, etc.).
In this PR, I’ve created the Firmware window in
mintupdate
(GTK3) to get as close as possible to GNOME Firmware’s UX and feature set, while staying within GTK3 limitations.What’s new:
LicenseRef-proprietary
is displayed as “Proprietary”.FwupdRequest
after install (Action Required / Further Action Required). Post-install prompt for Reboot/Shutdown based on device flags.get_details_async(path)
→ select device → confirm →install_async
or CLI fallback.modify_remote_async
), refresh (refresh_remote_async
), and “Upload Device List” (JSON preview + copy + upload via API or CLI fallback).GtkRevealer
+GtkProgressBar
, extended mapping forFwupd.Status
(Downloading, Installing, Device Read/Write/Erase/Verify, Waiting for auth/user, etc.).Ctrl+R
(refresh),Ctrl+I
(install from file).fwupdmgr
viapkexec
). Defensive coding for multiple fwupd/GIR versions.Limitations:
Modified files:
mintupdate/usr/lib/linuxmint/mintUpdate/firmwarewindow.py
mintupdate/usr/share/linuxmint/mintupdate/firmware.ui
Thanks for reviewing! Any feedback on UX, GNOME Firmware compatibility, and real hardware testing is very welcome.