[WIP] Update cs_screensaver to handle new Weather widget#12516
Open
queenkjuul wants to merge 2 commits intolinuxmint:masterfrom
Open
[WIP] Update cs_screensaver to handle new Weather widget#12516queenkjuul wants to merge 2 commits intolinuxmint:masterfrom
queenkjuul wants to merge 2 commits intolinuxmint:masterfrom
Conversation
clefebvre
changed the title
A1exKH
suggested changes
Dec 8, 2024
Author
|
@A1exKH sorry, completely lost track of this; updated |
clefebvre
changed the title
Member
|
Please remove the potfile changes, that is done by the maintainers. We don't want the vscode file either. |
clefebvre
changed the title
queenkjuul
force-pushed
the
screensaver-weather
branch
from
336a6d8 to
3b878ac
Compare
Author
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are necessary to enable the Screensaver Weather widget as proposed here:
linuxmint/cinnamon-screensaver#464
I have relocated the "Away Message" controls from the Customize page to the Settings page, as the additional Weather fields on the Customize page caused the window to be too tall by default. I thought Away Message was the most "settings-like" of the Customize page options.
Schema updates are made in cinnamon-desktop here:
linuxmint/cinnamon-desktop#246