Accessibility Improvements and general refactor #747

cjyabraham · 2023-03-09T19:45:14Z

Accessibility improvements, see issue Improve Accessibility #673
Does a big refactor of theme code into the MU plugin
Splits the MU plugin into different files, ala CNCF
Disables xmlrpc in order to reduce security attack surface and performance degradation
Closes Remove WordPress version from styles and scripts versions #751
Closes Turn off XML-RPC #749
Closes Misc updates to improve admin experience #746

Dev instance

On deploy:

Configure PublishPress to insist on image alt tags prior to publishing.
Update all HubSpot newsletter forms to have labels
Re-run page speed tests
Re-save image blocks where we want them to be fully accessible

cjyabraham · 2023-03-11T19:58:54Z

For the work so far, measuring the Kubecon EU main page:

Before

After

… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Signed-off-by: James Hunt <[email protected]>

… mention Signed-off-by: James Hunt <[email protected]>

Signed-off-by: James Hunt <[email protected]>

…751 Signed-off-by: James Hunt <[email protected]>

Signed-off-by: James Hunt <[email protected]>

thetwopct · 2023-03-14T17:56:58Z

Before

Using pagespeed.web.dev on the current site - home page:

Using pagespeed.web.dev on the current site - KCCNC EU 23:

Signed-off-by: James Hunt <[email protected]>

…URLs to use filemtime Signed-off-by: James Hunt <[email protected]>

Signed-off-by: James Hunt <[email protected]>

Signed-off-by: Chris Abraham <[email protected]>

Signed-off-by: James Hunt <[email protected]>

cjyabraham · 2023-03-23T16:18:17Z

web/wp-content/themes/lfevents/src/assets/scss/components/_forms.scss

+
+.searchandfilter .sf-input-text {
+  &:focus,
+  &:focus-within {


Ooh focus-within! That's a new one for me!

Signed-off-by: Chris Abraham <[email protected]>

cjyabraham · 2023-03-23T17:08:29Z

I was looking into the request for Kubecon NA to show different images in the hero of the site depending on whether it’s desktop or mobile. My experience is that it currently works on the dev site but does not work on this PR, with the newly updated conditional blocks pro plugin. I have reported the bug to the plugin author as follows:

We just upgraded to version 3.0.1 and the screen size conditions no longer seem to do anything on the site. They used to work fine with the previous version we were running, version 2.6.0. Any ideas on how to fix?

Signed-off-by: Chris Abraham <[email protected]>

cjyabraham · 2023-03-25T02:14:27Z

I have rolled back to the old version of conditional blocks pro as the new version has a bug

Signed-off-by: Chris Abraham <[email protected]>

cjyabraham · 2023-03-27T06:01:18Z

After

Using pagespeed.web.dev on the current site - home page:

Using pagespeed.web.dev on the current site - KCCNC EU 23:

cjyabraham changed the title ~~Accessibility Improvements~~ Accessibility Improvements and general refactor Mar 11, 2023

thetwopct force-pushed the accessibility branch 2 times, most recently from 6035296 to befeef0 Compare March 14, 2023 16:16

cjyabraham and others added 26 commits March 15, 2023 00:06

Supplies alt text for sponsor images; adds meta attribute for sponsor…

b2aea7f

… logo to override value. (#673) Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Added PublishPress plugin

a936bd8

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

improved accessibility of speakers block

570bacc

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Add alt text for LF logo

951fb74

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Improve accessibility of hamburger menu

47b2473

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Disables xmlrpc; refactors theme code into MU plugin

b2107c9

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

More refactoring code into the MU plugin

8e4dda9

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Refactoring of the MU plugin

35aeeb6

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Update dev docs

eb151c0

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

plugin upgrade

527c6d3

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Upgrade Conditional Blocks Pro

c51b8c2

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

invalid aria role

635c42a

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

add role values so the aria attributes that get added make sense

5a5fc7f

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

switch aria role to "button"

b30489e

Signed-off-by: Chris Abraham <[email protected]> Signed-off-by: James Hunt <[email protected]>

Updating plugins

fe43d60

Signed-off-by: James Hunt <[email protected]>

Removing unused files from theme

214ade3

Signed-off-by: James Hunt <[email protected]>

Updating gitignore for VS code workspace

ee0d62f

Signed-off-by: James Hunt <[email protected]>

Updating developer guidelines, updating lando default, removing Percy…

a51075b

… mention Signed-off-by: James Hunt <[email protected]>

Update Gulpfile to remove image optimization

000f998

Signed-off-by: James Hunt <[email protected]>

Fix code sniffs in MU plugin files

edafe37

Signed-off-by: James Hunt <[email protected]>

#749 Adding xml-rpc prevention filters

804c036

Signed-off-by: James Hunt <[email protected]>

Adding xmlrpc to Pantheon protected routes

82702a1

Signed-off-by: James Hunt <[email protected]>

Remove unused Foundation scripts and theme tidying, remove WP version #…

eaa4312

…751 Signed-off-by: James Hunt <[email protected]>

#746 Adding columns to CPTs to help manage the posts at a glance

35366cd

Signed-off-by: James Hunt <[email protected]>

Remove shorthand php function, fix code sniffs

6486603

Signed-off-by: James Hunt <[email protected]>

Remove more foundation press unused code

0fef34b

Signed-off-by: James Hunt <[email protected]>

#673 Adding form label fix, make very small text slightly bigger

409e03d

Signed-off-by: James Hunt <[email protected]>

thetwopct force-pushed the accessibility branch from 67d9e0d to 409e03d Compare March 14, 2023 17:06

#673 Updating Image Box to take alt text from title of image box

18bcc08

Signed-off-by: James Hunt <[email protected]>

thetwopct added 7 commits March 16, 2023 00:07

#673 Caption on tables

5adee70

Signed-off-by: James Hunt <[email protected]>

#673 Making navigation keyboard accessible

4e9e7e9

Signed-off-by: James Hunt <[email protected]>

#673 Adding skip link

7ec1053

Signed-off-by: James Hunt <[email protected]>

Removing SVG favicon link as file does not exist

5b9c9d2

Signed-off-by: James Hunt <[email protected]>

#673 Updating Image Box with aria-label on link

0bd57ad

Signed-off-by: James Hunt <[email protected]>

#751 Experiental script and style loader filter to make ver in asset …

30ccb15

…URLs to use filemtime Signed-off-by: James Hunt <[email protected]>

Fix code sniffs

e2badec

Signed-off-by: James Hunt <[email protected]>

thetwopct marked this pull request as ready for review March 17, 2023 03:57

cjyabraham and others added 5 commits March 17, 2023 16:15

fix contrast on form input placeholders

a13406e

Signed-off-by: Chris Abraham <[email protected]>

make cookie less colorful and clashing

bd76ac4

Signed-off-by: Chris Abraham <[email protected]>

plugin upgrades

82b3e8e

Signed-off-by: Chris Abraham <[email protected]>

remove outline on cookie when focused

bd733a9

Signed-off-by: Chris Abraham <[email protected]>

Adding placeholder change color on focus

d52aa19

Signed-off-by: James Hunt <[email protected]>

cjyabraham commented Mar 23, 2023

View reviewed changes

Apply placeholder transition to newsletter forms

e32b34e

Signed-off-by: Chris Abraham <[email protected]>

roll back to v2.6.0 of conditional blocks pro

5463aa3

Signed-off-by: Chris Abraham <[email protected]>

add "headshot" to alt tag as requested

af43bf2

Signed-off-by: Chris Abraham <[email protected]>

cjyabraham merged commit f27e094 into main Mar 27, 2023

cjyabraham deleted the accessibility branch March 27, 2023 04:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Accessibility Improvements and general refactor #747

Accessibility Improvements and general refactor #747

cjyabraham commented Mar 9, 2023 •

edited

Loading

cjyabraham commented Mar 11, 2023 •

edited

Loading

thetwopct commented Mar 14, 2023 •

edited

Loading

cjyabraham Mar 23, 2023

cjyabraham commented Mar 23, 2023 •

edited

Loading

cjyabraham commented Mar 25, 2023

cjyabraham commented Mar 27, 2023

Accessibility Improvements and general refactor #747

Accessibility Improvements and general refactor #747

Conversation

cjyabraham commented Mar 9, 2023 • edited Loading

cjyabraham commented Mar 11, 2023 • edited Loading

thetwopct commented Mar 14, 2023 • edited Loading

Before

cjyabraham Mar 23, 2023

Choose a reason for hiding this comment

cjyabraham commented Mar 23, 2023 • edited Loading

cjyabraham commented Mar 25, 2023

cjyabraham commented Mar 27, 2023

After

cjyabraham commented Mar 9, 2023 •

edited

Loading

cjyabraham commented Mar 11, 2023 •

edited

Loading

thetwopct commented Mar 14, 2023 •

edited

Loading

cjyabraham commented Mar 23, 2023 •

edited

Loading