Update toolchain to uv; add more linting #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Searcy <[email protected]>
Signed-off-by: Eric Searcy <[email protected]>
This is a dependency of boto3, but we also explicitly import from it, so it should be listed in requirements.in. Signed-off-by: Eric Searcy <[email protected]>
jpmcb
reviewed
Dec 3, 2024
| pyenv install 3.11 | ||
| pipenv install | ||
| pipenv shell | ||
| pyenv install 3.12 # or: brew install [email protected]; brew pyenv-sync |
There was a problem hiding this comment.
This is slightly redundant since the uv venv step will see the .python-version and grab a uv managed Python with the correct version (and doesn't need that version on the system to be installed):
❯ make .venv
uv venv .venv
Using CPython 3.12.7
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
❯ which python
/Users/jpmcb/workspace/linuxfoundation/cdn-maintenance-toggle/.venv/bin/python
❯ python --version
Python 3.12.7
Comment on lines
-39
to
+43
| pip3.11 install --user boto3 trieregex | ||
| pip install --user boto3 trieregex | ||
| # Optional: to set AWS_PROFILE or other parameters via .env: | ||
| # pip3.11 install --user python-dotenv | ||
| # pip install --user python-dotenv |
There was a problem hiding this comment.
If the user has the .venv setup and got the packages installed via the make sync command, they shouldn't need to manually install those pacakges. Note that these packages land in the virtual env managed by uv:
❯ ll .venv/lib/python3.12/site-packages
total 96
-rw-r--r--@ 1 jpmcb staff 18B Dec 2 16:47 _virtualenv.pth
-rw-r--r--@ 1 jpmcb staff 4.2K Dec 2 16:47 _virtualenv.py
drwxr-xr-x@ 15 jpmcb staff 480B Dec 2 16:48 boto3
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 boto3-1.35.72.dist-info
drwxr-xr-x@ 48 jpmcb staff 1.5K Dec 2 16:48 botocore
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 botocore-1.35.72.dist-info
drwxr-xr-x@ 13 jpmcb staff 416B Dec 2 16:48 dateutil
drwxr-xr-x@ 11 jpmcb staff 352B Dec 2 16:48 dotenv
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 jmespath
drwxr-xr-x@ 9 jpmcb staff 288B Dec 2 16:48 jmespath-1.0.1.dist-info
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 python_dateutil-2.9.0.post0.dist-info
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 python_dotenv-1.0.1.dist-info
drwxr-xr-x@ 18 jpmcb staff 576B Dec 2 16:48 s3transfer
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 s3transfer-0.10.4.dist-info
drwxr-xr-x@ 9 jpmcb staff 288B Dec 2 16:48 six-1.16.0.dist-info
-rw-r--r--@ 1 jpmcb staff 34K Dec 2 16:48 six.py
drwxr-xr-x@ 10 jpmcb staff 320B Dec 2 16:48 tests
drwxr-xr-x@ 5 jpmcb staff 160B Dec 2 16:48 trieregex
drwxr-xr-x@ 9 jpmcb staff 288B Dec 2 16:48 trieregex-1.0.0.dist-info
drwxr-xr-x@ 16 jpmcb staff 512B Dec 2 16:48 urllib3
drwxr-xr-x@ 9 jpmcb staff 288B Dec 2 16:48 urllib3-1.26.20.dist-info
If you wanted to be sure the end user has those packages installed in the venv, they can do it through the uv pip interface:
uv pip install python-dotenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.