Repository navigation
chore: replace Qt keywords with macros (QT_NO_KEYWORDS) - #1788
18202781743 wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe PR enables QT_NO_KEYWORDS and systematically migrates Qt keyword syntax to Q_EMIT/Q_SIGNALS/Q_SLOTS, while normalizing SPDX years; however, the diff also deletes notifyaccessor.cpp and contains extensive accidental line-collapsing changes that should be carefully reviewed or reverted before merging. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid naming conflicts with pure C++ or third-party libraries. Also fix SPDX copyright headers and add QT_NO_KEYWORDS compile definition. Log: 1. Replace Qt keywords (emit/signals/slots) with macro forms (Q_EMIT/Q_SIGNALS/Q_SLOTS) 2. Add QT_NO_KEYWORDS compile definition in CMakeLists.txt after project() 3. Fix SPDX-FileCopyrightText year ranges to end in 2026 4. Add SPDX headers to CMakeLists.txt files that were missing them Influence: 1. No behavioral change, only keyword-to-macro replacement chore: 替换 Qt 关键字为宏形式 将 emit/signals:/slots: 替换为 Q_EMIT/Q_SIGNALS:/Q_SLOTS:, 避免纯 C++ 或第三方库引入时的命名冲突。同时修复 SPDX 版权头并 添加 QT_NO_KEYWORDS 编译定义。 Log: 1. 将 Qt 关键字(emit/signals/slots)替换为宏形式(Q_EMIT/Q_SIGNALS/Q_SLOTS) 2. 在 CMakeLists.txt 中 project() 之后添加 QT_NO_KEYWORDS 编译定义 3. 修复 SPDX-FileCopyrightText 年份范围,终止年份统一为 2026 4. 为缺失 SPDX 头的 CMakeLists.txt 文件添加版权头 Influence: 1. 无行为变更,仅关键字到宏的替换
9da8a76 to
8a3bf79
Compare
Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid naming conflicts with pure C++ or third-party libraries.
Also adds QT_NO_KEYWORDS compile definition in CMakeLists.txt and fixes SPDX copyright year ranges.
Related issue: DDE-499
Summary by Sourcery
Adopt Qt's macro-based signal, slot, and emit syntax and enable QT_NO_KEYWORDS across the project.
Enhancements:
Build:
Tests:
Chores: