Topic/syslog #29

quic-bhaskarv · 2025-08-10T10:09:26Z

Request to merge below changes:

Fix compilation issues when all warnings are enabled as errors
Syslog based logging for the server. This will allow debugging Server issues.
Server configuration through config file. This allows customizing the server for Linux build flavor
Sample configuration file. This provides reference to configuring the server.

lumag

All commit messages should start with the description of an issue: 'Foo ABC is bad, change it to be BAR.'

lumag · 2025-08-11T09:34:42Z

meson.build

           tqftpserv_srcs,
-           dependencies : [qrtr_dep, zstd_dep],
+           dependencies : [qrtr, zstd_dep],
+           c_args : ['-g', '-Wall', '-Werror', '-Wsign-compare', '-Wunused-parameter', '-Wtype-limits', '-Wimplicit-function-declaration'],


This is obviosly an abuse of dependencies and it might break for non-gcc compilers. Please use add_global_arguments to add build options.

I added arguments using add_project_arguments

lumag · 2025-08-11T09:36:59Z

tqftpserv.c

 	}

-	if (tsize && *tsize != -1) {
+	if (tsize && *tsize != (size_t)-1) {


Change tsize to ssize_t

lumag · 2025-08-11T09:37:08Z

tqftpserv.c

 		/* Header (4 bytes) + data size */
 		send_len = 4 + response_size;
-		if (send_len > p - buf) {
+		if (send_len > (size_t)(p - buf)) {


changed send_len from size_t to ssize_t

lumag · 2025-08-11T09:37:38Z

zstd-decompress.c

 */

-/* For memfd_create */
-#define _GNU_SOURCE


Why? it was fine as is and it's not related to warnings

This macro needs to be defined for asprintf function usage in translate.c, so I moved it to meson.build

Please move it back and add another one in translate.c

lumag · 2025-08-11T09:38:46Z

zstd-decompress.c

 	}

-	if (write(output_file_fd, decompressed_buffer, decompressed_size) != decompressed_size) {
+	if (write(output_file_fd, decompressed_buffer, decompressed_size) != (ssize_t)decompressed_size) {


Change decompressed_size to size_t or ssize_t.

lumag · 2025-08-11T09:42:06Z

logging.c

+ *
+ * Return: Log facility constant on success, -1 on error
+ */
+int tqftp_parse_log_facility(const char *facility_str)


Always use daemon, no need to let it be logged as "uucp".

lumag · 2025-08-11T09:53:52Z

logging.c

+ * tqftp_log_init_with_config() - Initialize logging with custom configuration
+ * @config: Logging configuration structure
+ */
+void tqftp_log_init_with_config(struct tqftp_log_config *config)


I'd suggest using function calls instead of passing config around. I.e. set_min_level, use_console, etc.

configuration file will allow to run the server on various linux flavors without changing the server code. I added configuration support for command line arguments as well, I will remove them and have server access paths only.

Why? It's really easier to parse few command line options rather than having a config file parser.

We can add command line option, if we want to change the paths (based on the build type, android, LE, Ubuntu, etc) then we have to modify service file (or equivalent) that starts the server and this service file needs to be created based on variant.
With configuration file as well it would be similar (multiple configuration files) however, config files can be modified in on the fly for debugging. There are other tuning parameters that needs to be introduced, so I thought configuration file would be better than adding too many command line arguments.
Lets discuss which is better.

lumag · 2025-08-11T09:54:57Z

config.c

+ *
+ * Return: 0 on success, -1 on error
+ */
+int tqftp_config_load_file(struct tqftp_config *config, const char *filename)


Yikes. If you want to have a config file, use one of existing libraries. I'd recommend libconfig. Or just use command line options.

I tried using libconfig and it is not available for all builds, does it make sense to copy libconfig in this project (I don't like this though)?

No, it doesn't. What do you mean by it 'being not available for all builds'?

'What do you mean by it 'being not available for all builds'?
I attempted to build on Android flavor and it failed, I did some experiments and understood that libconfig is present and it needed to be enabled from base config file. I have used libconfig and posted new change.

lumag · 2025-08-11T09:57:00Z

logging.h

+
+/* Convenience macros for common logging patterns */
+#define TQFTP_LOG_ERROR(fmt, ...)   TQFTP_LOG_ERR(fmt, ##__VA_ARGS__)
+#define TQFTP_LOG_WARN(fmt, ...)    TQFTP_LOG_WARNING(fmt, ##__VA_ARGS__)


Why do we need these duplicates? Select one style and use it.

lumag · 2025-08-11T09:57:54Z

logging.h

+#define TQFTP_LOG_PERROR(msg) TQFTP_LOG_ERR("%s: %s", msg, strerror(errno))
+
+/* Macro to log system errors with custom format */
+#define TQFTP_LOG_ERRNO(fmt, ...) TQFTP_LOG_ERR(fmt ": %s", ##__VA_ARGS__, strerror(errno))


Again, select one style instead of having two very similar ones.

…r issues Resolve multiple compilation issues triggered by -Wall and -Werror flags: - Multiple warnings in in zstd_decompress_file function in zstd-decompress.h. - Eliminate redefinition of zstd_decompress_file between zstd-decompress.h and zstd-decompress.c. - Address pointer type mismatch in tqftpserv.c by correcting char * vs uint8_t * assignment. - Resolve signedness comparison issues in tqftpserv.c for send_len and tsize checks. - Remove unused parameters argc and argv in main() function of tqftpserv.c. These changes ensure clean compilation and adherence to strict warning policies. Change-Id: I1539433ec5122e0e6fc3c8e0d02900a040bc21de Signed-off-by: Bhaskar Valaboju <[email protected]>

Introduce a project-specific logging framework through syslog. Change-Id: Ie3399a58e9772f25979471cbf2f861ad1962d788 Signed-off-by: Bhaskar Valaboju <[email protected]>

Integrate configuration management via config file and command-line arguments to customize server behavior. This allows runtime configuration of key filesystem paths including readonly_path, readwrite_path, firmware_base, updates_dir, and temp_dir. It also enables dynamic adjustment of the default log level, supporting flexible deployment across platforms like Linux and Android without requiring code changes. Change-Id: I788ce0eb1052f43872800bc0f2e0cc5d0a6b442b Signed-off-by: Bhaskar Valaboju <[email protected]>

Integrate syslog-based logging into tqftpserv source files. Logging now leverages system-level facilities for consistent output and easier debugging. Signed-off-by: Bhaskar Valaboju <[email protected]>

Integrate configuration management via config file and command-line arguments to customize server behavior. This allows runtime configuration of key filesystem paths including readonly_path, readwrite_path, firmware_base, updates_dir, and temp_dir. It also enables dynamic adjustment of the default log level, supporting flexible deployment across platforms like Linux and Android without requiring code changes. Signed-off-by: Bhaskar Valaboju <[email protected]>

Provide a sample configuration file to support runtime customization of server paths and log level settings. Signed-off-by: Bhaskar Valaboju <[email protected]>

quic-bhaskarv · 2025-08-26T12:02:24Z

I addressed all the comments, it took time to validate on all flavors.

Integrate configuration management via config file and command-line arguments to customize server behavior. This allows runtime configuration of key filesystem paths including readonly_path, readwrite_path, firmware_base, updates_dir, and temp_dir. It also enables dynamic adjustment of the default log level, supporting flexible deployment across platforms like Linux and Android without requiring code changes. Change-Id: I788ce0eb1052f43872800bc0f2e0cc5d0a6b442b Signed-off-by: Bhaskar Valaboju <[email protected]>

quic-bhaskarv · 2025-09-03T03:00:44Z

Gentle Remainder!!!

quic-bhaskarv · 2025-09-22T09:27:55Z

Gentle Remainder !!!

quic-bhaskarv · 2025-09-22T09:29:59Z

Gentle Remainder, @lumag

lumag requested changes Aug 11, 2025

View reviewed changes

quic-bhaskarv added 6 commits August 26, 2025 13:49

tqftpserv: Add Syslog-based logging system

a6b58e3

Introduce a project-specific logging framework through syslog. Change-Id: Ie3399a58e9772f25979471cbf2f861ad1962d788 Signed-off-by: Bhaskar Valaboju <[email protected]>

tqftpserv: Enable syslog logging in tqftpserv

eb773fa

Integrate syslog-based logging into tqftpserv source files. Logging now leverages system-level facilities for consistent output and easier debugging. Signed-off-by: Bhaskar Valaboju <[email protected]>

tqftpserv: Add sample configuration file for tqftpserv

d2e90ce

Provide a sample configuration file to support runtime customization of server paths and log level settings. Signed-off-by: Bhaskar Valaboju <[email protected]>

quic-bhaskarv force-pushed the topic/syslog branch from 4551b96 to d2e90ce Compare August 26, 2025 08:43

Topic/syslog #29

Are you sure you want to change the base?

Topic/syslog #29

Uh oh!

Conversation

quic-bhaskarv commented Aug 10, 2025

Uh oh!

lumag left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quic-bhaskarv Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quic-bhaskarv commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quic-bhaskarv commented Sep 3, 2025

Uh oh!

quic-bhaskarv commented Sep 22, 2025

Uh oh!

quic-bhaskarv commented Sep 22, 2025

Uh oh!

Uh oh!

lumag left a comment •

edited

Loading

quic-bhaskarv Aug 13, 2025 •

edited

Loading

quic-bhaskarv commented Aug 26, 2025 •

edited

Loading