-
Notifications
You must be signed in to change notification settings - Fork 109
Apply UseStateForUnknown for hosts of database instances
#2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Apply UseStateForUnknown for hosts of database instances
#2174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves issue #2085 by applying the UseStateForUnknown() plan modifier to the host_primary and host_secondary computed attributes in database resources. This prevents unnecessary updates to dependent resources when the database configuration changes but the host values remain the same.
Key changes:
- Added
UseStateForUnknown()plan modifier to host attributes in PostgreSQL v2 database schema - Added
UseStateForUnknown()plan modifier to host attributes in MySQL v2 database schema
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linode/databasepostgresqlv2/framework_resource_schema.go | Added plan modifiers to preserve host values during updates |
| linode/databasemysqlv2/framework_resource_schema.go | Added plan modifiers to preserve host values during updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vshanthe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
|
Blocked by #2176 |
📝 Description
Resolve #2085
✔️ How to Test
First Step
Apply this TF config:
Second Step
Change the
allow_list, then apply again.