feat: [none] Add ctrl+alt+del button to Glish#13514
Open
slepix wants to merge 1 commit intolinode:developfrom
Open
feat: [none] Add ctrl+alt+del button to Glish#13514slepix wants to merge 1 commit intolinode:developfrom
slepix wants to merge 1 commit intolinode:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Even though Windows are not officially supported, this PR add a "CTRL+ALT+DEL" button in Glish console and brings us a small step closer to supporting Windows.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Up to your discretion
Preview 📷
Preview of Glish working for both Linux and Windows VM's.

Windows VM on the login screen, waiting for CTRL+ALT+DEL combo to be sent:

Windws VM after the CTRL+ALT+DEL button was pressed.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.
|


|
|
How to test 🧪
Open Glish on a Windows based VM and press the CTRL+ALT+DEL button
Prerequisites
Regular environment setup. For windows VM use https://github.com/kitknox/winode
Verification steps
(How to verify changes)
Open Glish on a Windows based VM and press the CTRL+ALT+DEL button
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅