Skip to content

test: [DI-30129] - Add spec for show details notification channel#13449

Open
shnagend-akamai wants to merge 14 commits intolinode:developfrom
shnagend-akamai:show_notification_channel_details_automation_linode_February_28
Open

test: [DI-30129] - Add spec for show details notification channel#13449
shnagend-akamai wants to merge 14 commits intolinode:developfrom
shnagend-akamai:show_notification_channel_details_automation_linode_February_28

Conversation

@shnagend-akamai
Copy link
Contributor

@shnagend-akamai shnagend-akamai commented Feb 28, 2026

Description 📝

This PR introduces integration test coverage for the Notification Channel Show Details page in the CloudPulse Alerts section of the Linode Manager application.

Changes 🔄

Adds show details spec with integration tests for the Notification Channel Show Details page.
Covers detail validation, Associated Alerts table (search, filter, sort, pagination), and navigation to alert detail pages.
Handles error scenarios: 500 responses for channel/alerts fetches, empty alerts state, and channel load failure.
Adds API intercepts and enables all seven service types to prevent alerts from being filtered out during tests.
Also fixes few existing test specs to accept CloudPulseServiceMap updated values.

Target release date 🗓️

Upcoming release

Preview 📷

alert-show-notification-channel.spec.ts.2.mp4

How to test 🧪

pnpm cy:run -s "cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts"

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@shnagend-akamai shnagend-akamai marked this pull request as ready for review February 28, 2026 08:02
@shnagend-akamai shnagend-akamai requested a review from a team as a code owner February 28, 2026 08:02
@santoshp210-akamai santoshp210-akamai added Cloud Pulse Testing Cloud Pulse - Alerting e2e Indicates that a PR touches Cypress tests in some way and removed Cloud Pulse labels Mar 2, 2026
Copy link
Collaborator

@kmuddapo kmuddapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 4, 2026
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shnagend-akamai the only thing stopping me from approving is the const assignments which aren't valid in Cypress. Feel free to ping me in Slack if I can lend a hand 👍

@shnagend-akamai
Copy link
Contributor Author

shnagend-akamai commented Mar 16, 2026

@dmcintyr-akamai, @jdamore-linode have addressed the review comments raised previously. Can you please re-review once ?

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #14 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing886 Passing11 Skipped40m 31s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on » creates an LKE-E cluster with the account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cloud Pulse - Alerting e2e Indicates that a PR touches Cypress tests in some way Testing

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

8 participants