ref: update monitor API docstring#702
Draft
shkaruna wants to merge 1 commit into
Draft
Conversation
yec-akamai
added
community-contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Update ACLP monitor group doc strings.
Monitor APIs support both v4beta & v4 versions
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
NA
How do I run the relevant unit/integration tests?
Unit tests:
Run all unit tests:
python -m pytest test/unit -q
452 passed, 7 warnings in 1.11s
Run Monitor alert unit tests:
=================================================== test session starts ===================================================
platform linux -- Python 3.10.12, pytest-9.0.3, pluggy-1.6.0
rootdir: /home/shkaruna/sdk/linode_api4-python
configfile: pyproject.toml
plugins: rerunfailures-16.1, anyio-4.13.0
collected 4 items
test/unit/groups/monitor_api_test.py ....
==================================================== 4 passed in 0.14s ====================================================
Integration tests with v4 & v4beta
v4beta
python -m pytest test/integration/models/monitor/test_monitor.py::test_alert_definition_entities -q -s
.
1 passed in 3.00s
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
.
1 passed in 10.66s
v4
export LINODE_API_URL=https://api.linode.com/v4
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
Running monitor alert-definition integration test against base_url: https://api.linode.com/v4
.
1 passed in 11.88s