Skip to content

chore: return notFound when disk isn't attached #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: return notFound when disk isn't attached #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/driver/nodeserver_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (ns *NodeServer) findDevicePath(ctx context.Context, key linodevolumes.Lino

// If no device path is found, return an error.
if devicePath == "" {
return "", errInternal("Unable to find device path out of attempted paths: %v", devicePaths)
return "", errNotFound("Unable to find device path out of attempted paths: %v", devicePaths)
}

// If a device path is found, return it.
Expand Down
2 changes: 1 addition & 1 deletion internal/driver/nodeserver_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func TestNodeServer_findDevicePath(t *testing.T) {
dUtils.EXPECT().VerifyDevicePath(gomock.Any()).Return("", nil)
},
wantDevicePath: "",
wantErr: errInternal("Unable to find device path out of attempted paths: [some/path]"),
wantErr: errNotFound("Unable to find device path out of attempted paths: [some/path]"),
},
{
name: "Success",
Expand Down
Loading