Skip to content

Update rotation flow #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update rotation flow #2011

wants to merge 9 commits into from

Conversation

GTRekter
Copy link
Contributor

@GTRekter GTRekter commented Aug 4, 2025

No description provided.

@GTRekter GTRekter changed the title Update roation flow Update rotation flow Aug 4, 2025
@travisbeckham travisbeckham requested a review from kflynn August 4, 2025 15:09
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one comment that I think is an important change (the first comment), and others which might warrant changes, or might not. Thanks for putting the work in here!! 🙂

2. Restart the data plane
3. Trigger identity issuer rotation
4. Restart the control plane
5. Restart the data plane
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you only need this restart if you can't wait for workload certs to expire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment like

  1. xxxx
  2. xxxx
Note: Steps 4 and 5 are optional and will force the signing of a new workload certificate by the new identity issuer.
  1. xxx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more I think about this, the more I think we leave step 5 as restarting the data plane -- but maybe add a note after the list about "At step 5, you could also simply wait for workload certificates to be reissued."?

3. Trigger identity issuer rotation
4. Restart the control plane
5. Restart the data plane
6. Remove the old anchor from the trust bundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must happen after all the proxies have new workload certs, if you chose not to wait in step 5.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a disclaimer before the point 6 to highlight the importance of waiting for all the proxy to be restarted before moving forward?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, absolutely.

Signed-off-by: Ivan Porta <[email protected]>
@GTRekter GTRekter requested a review from kflynn August 13, 2025 15:10
travisbeckham and others added 8 commits August 14, 2025 00:19
* 202508 Edge Release Roundup

Signed-off-by: Flynn <[email protected]>

* Lint

Signed-off-by: Flynn <[email protected]>

* Upgrade graphics

Signed-off-by: Flynn <[email protected]>

* Date change

Signed-off-by: Flynn <[email protected]>

* Fix broken slugs 🤦‍♂️

Signed-off-by: Flynn <[email protected]>

---------

Signed-off-by: Flynn <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
* Added Blake Romano as Linkerd Ambassador

Signed-off-by: Travis Beckham <[email protected]>

* Optimized Ambassador images

Signed-off-by: Travis Beckham <[email protected]>

---------

Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
@GTRekter
Copy link
Contributor Author

There has been a rebase with a lot of files coming changes. It might be better to create a new PR to keep it clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants