Skip to content

Fix typo in the "Distributed tracing with Linkerd" page #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GTRekter
Copy link
Contributor

It's treating the config as a string rather than as an object.

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Ouch -- thanks for the catch!! 🙂

@cratelyn
Copy link
Collaborator

@GTRekter i believe you'll need to amend your commit and add a DCO (developer certificate of origin) described here.

you can run something like:

git amend --signoff --no-edit && git push --force-with-lease

from your branch to push a new, amended commit.

@travisbeckham
Copy link
Collaborator

I think this needs to be fixed in 2-edge also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants