Adding custom deployment annotations to control plane helm charts #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed off by: Gustavo Vera Heredia<[email protected]> Signed-off-by: Gustavo Vera Heredia <[email protected]>
gustavovera
force-pushed
the
feat/addingDeploymentAnnotations
branch
from
90c31aa to
fb24220
Compare
|
Thanks! happy to receive feedback to make the checks pass! |
|
Thanks for your patience on this, @gustavovera! In order to be consistent, how would you feel about following the pattern of |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding custom deployment annotations to control plane helm charts
There is no option to add custom deployment annotations to the control plane
Enhance the helm values.yaml to add a commonDeploymentAnnotations object following the commonLabels approach.
Documentation and templated helm chart
Fixes #13317
Signed-off-by: Gustavo Vera Heredia [email protected]