[duckdb] Created a CLI tool to interact with DuckDBDaVinciRecordTransformer #1473
+528
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
reviewed
Jan 24, 2025
...e-duckdb/src/main/java/com/linkedin/venice/duckdb/DuckDBDaVinciRecordTransformerExample.java
Outdated
Show resolved
Hide resolved
...e-duckdb/src/main/java/com/linkedin/venice/duckdb/DuckDBDaVinciRecordTransformerExample.java
Outdated
Show resolved
Hide resolved
...e-duckdb/src/main/java/com/linkedin/venice/duckdb/DuckDBDaVinciRecordTransformerExample.java
Outdated
Show resolved
Hide resolved
...e-duckdb/src/main/java/com/linkedin/venice/duckdb/DuckDBDaVinciRecordTransformerExample.java
Outdated
Show resolved
Hide resolved
kvargha
changed the title
lusong64
reviewed
Feb 3, 2025
|
|
||
| Options parameterOptionsForHelp = new Options(); | ||
| for (Object obj: options.getOptions()) { | ||
| Option o = (Option) obj; |
There was a problem hiding this comment.
should we use instanceOf to check whether the obj is an Option or we are pretty sure they are?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[duckdb] Created a CLI tool to interact with DuckDBDaVinciRecordTransformer
This PR creates a CLI tool to interact with DuckDBDaVinciRecordTransformer, similar to the AdminTool.
How was this PR tested?
I tested this locally pointed to a store that exists, but for the purpose of releasing this to OSS I generalized the variables.
Does this PR introduce any user-facing changes?