Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller][grpc] Add ClusterAdminOpsGrpcService with handler and tests #1458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sushantmane
Copy link
Collaborator

@sushantmane sushantmane commented Jan 18, 2025

Add ClusterAdminOpsGrpcService with handler and tests

[controller][grpc] Add ClusterAdminOpsGrpcService with handler and tests

  • Added ClusterAdminOpsGrpcServiceImpl to support gRPC-based cluster admin operations.
  • Implemented methods for admin command status, metadata, and execution ID retrieval.
  • Introduced ClusterAdminOpsRequestHandler for handling gRPC service requests.
  • Added unit tests for the service and request handler to validate functionality.

Note: This is a stacked PR. Please review PR #1454 first OR focus on 0c69ab5. Thank you!

How was this PR tested?

UT

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

- Introduced `ClusterAdminOpsGrpcServiceImpl` for gRPC support of cluster admin
operations.

- Added `ClusterAdminOpsRequestHandler` for handling gRPC requests.

- Implemented all relevant methods in the service, including admin command status,
metadata handling, and execution ID retrieval.

- Provided comprehensive TestNG tests for the service and request handler.
@sushantmane sushantmane force-pushed the grpc-in-venice-control-plane-cluster-admin-ops branch from 0c69ab5 to 28352ee Compare January 23, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant