Fix race condition vulnerability in temporary directory creation #1050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the
createTmpDir()
method in ExporterTestUtils.java by replacing the older implementation with the Java NIO.2 Files API.The previous implementation has a potential race condition vulnerability between deleting the temp file and creating a directory with the same name plus suffix. During this window, another process could potentially create a file or directory at the target path.
The new implementation using Files.createTempDirectory() eliminates this vulnerability by performing the operation atomically.
A similar fix can be found here openkm/document-management-system#332
Changes
Files.createTempDirectory()
java.nio.file.Files
References
openkm/document-management-system#332
openkm/document-management-system@c069e4d