-
Notifications
You must be signed in to change notification settings - Fork 307
[WIP] Update benchmark data #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tcc0403 <[email protected]>
Signed-off-by: Tcc0403 <[email protected]>
@shivam15s @lancerts @yundai424
|
Perhaps we can do an official benchmark whenever a new version is released. Along with the PR that bumps the version in pyproject.toml, we can add the latest benchmark result -- this way we can let git history to help us keep track of the performance 😄 would like to hear your opinion. |
Strong +1, which can also help detect performance regression early. |
1 I don't think we need to keep the old data. |
Totally agree! An official benchmark result is defintely better.
Besides the benchmark along with new releases, I think it would be great to have additional benchmark for nightly (or do it weekly), so we can detect performance regression earlier and handle it before version bump. Is it possible to setup a scheduled ci to periodically udpate the nightly benchmark? If so, instead of the current |
agree 🤔 ideally something like https://hud.pytorch.org/benchmark/compilers and host the results somewhere else on server so we don't flush git history with bunch of benchmark numbers.. |
Summary
Rerun all benchmarks scripts to get the latest data, so we can have a reliable baseline for future optimization.
Note: orpo failing with
compile=True
(plotting with old data for now), qwen2vl_mrope script failed.A complete comparison figure will be uploaded in this PR later.
Fused Linear Chunked Loss
Alignment
CPO
speed
DPO
speed
KTO
speed
ORPO
speed
SimPO
speed
Distillation
speed
Others
Cross Entropy
speed
Fused Linear Cross Entropy
speed
JSD
speed
Fused Linear JSD
speed
DyT
speed
Embedding
speed
GeGLU
speed
GroupNorm
speed
KL Div
speed
LayerNorm
speed
RMSNorm
speed
RoPE
speed
Swiglu
speed
TVD
speed
Testing Done
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence