Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xunit from 2.6.6 to 2.7.0 #260

Merged
merged 1 commit into from
Mar 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/json-ld.net.tests/json-ld.net.tests.csproj
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="6.0.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="xunit" Version="2.6.6" />
<PackageReference Include="xunit" Version="2.7.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.7" />
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
</ItemGroup>

Unchanged files with check annotations Beta

public class ConformanceTests
{
[Theory, ClassData(typeof(ConformanceCases))]
public void ConformanceTestPasses(string id, ConformanceCase conformanceCase)

Check warning on line 16 in test/json-ld.net.tests/ConformanceTests.cs

GitHub Actions / build

Theory method 'ConformanceTestPasses' on test class 'ConformanceTests' does not use parameter 'id'. Use the parameter, or remove the parameter and associated data. (https://xunit.net/xunit.analyzers/rules/xUnit1026)

Check warning on line 16 in test/json-ld.net.tests/ConformanceTests.cs

GitHub Actions / build

Theory method 'ConformanceTestPasses' on test class 'ConformanceTests' does not use parameter 'id'. Use the parameter, or remove the parameter and associated data. (https://xunit.net/xunit.analyzers/rules/xUnit1026)
{
JToken result = conformanceCase.run();
if (conformanceCase.error != null)
Console.WriteLine("--------------------------");
#endif
Assert.True(false, "Returned JSON doesn't match expectations.");

Check warning on line 37 in test/json-ld.net.tests/ConformanceTests.cs

GitHub Actions / build

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Check warning on line 37 in test/json-ld.net.tests/ConformanceTests.cs

GitHub Actions / build

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)
}
}
}
private const string ManifestRoot = "ExtendedFunctionality";
[Theory, MemberData(nameof(ExtendedFunctionalityCases))]
public void ExtendedFunctionalityTestPasses(string id, ExtendedFunctionalityTestCase testCase)

Check warning on line 16 in test/json-ld.net.tests/ExtendedFunctionalityTests.cs

GitHub Actions / build

Theory method 'ExtendedFunctionalityTestPasses' on test class 'ExtendedFunctionalityTests' does not use parameter 'id'. Use the parameter, or remove the parameter and associated data. (https://xunit.net/xunit.analyzers/rules/xUnit1026)

Check warning on line 16 in test/json-ld.net.tests/ExtendedFunctionalityTests.cs

GitHub Actions / build

Theory method 'ExtendedFunctionalityTestPasses' on test class 'ExtendedFunctionalityTests' does not use parameter 'id'. Use the parameter, or remove the parameter and associated data. (https://xunit.net/xunit.analyzers/rules/xUnit1026)
{
JToken result = testCase.run();
if (testCase.error != null)
Console.WriteLine("--------------------------");
#endif
Assert.True(false, "Returned JSON doesn't match expectations.");

Check warning on line 37 in test/json-ld.net.tests/ExtendedFunctionalityTests.cs

GitHub Actions / build

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)

Check warning on line 37 in test/json-ld.net.tests/ExtendedFunctionalityTests.cs

GitHub Actions / build

Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead. (https://xunit.net/xunit.analyzers/rules/xUnit2020)
}
}
}