Move applications into separate crates #423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the service and contract to be binaries instead of example targets. Requires marking them as not having `main` functions.
Now that the Counter application has been moved, the path where its binaries are placed in has changed, so the tests must be updated.
Change the service and contract to be binaries instead of example targets. Requires marking them as not having `main` functions. Also change how the modules are organized, with `interface` becoming a library target, and the `types` module only being accessed through the library.
Update the Crowd-Funding application to use the Fungible Token application crate directly.
Change the service and contract to be binaries instead of example targets. Requires marking them as not having `main` functions.
Update the crates necessary to build for running tests.
ma2bd
approved these changes
Feb 4, 2023
| @@ -2,15 +2,13 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| #![cfg(target_arch = "wasm32")] | |||
There was a problem hiding this comment.
Apparently, in order to fix all the clippy errors in CI, one has to remove all the lines #![cfg(target_arch = "wasm32")] in contract.rs and service.rs files.
There was a problem hiding this comment.
Actually this is more tricky than that. Ideally, the workspace would handle different targets but this is not supported yet: rust-lang/cargo#5220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some example applications have been written and placed in
linera-sdk/examples. However, having the applications interact among themselves and writing test code outsidelinera-sdkthat interacts with the applications is hard because none of the necessary types are exported through a crate.Solution
Create a separate crate per application in a
linera-examplessub-directory.