Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#186 add toggle function to show and hide contact menu #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asmaNode
Copy link
Contributor

@asmaNode asmaNode commented Mar 1, 2022

Demo :

closeandhidemenuContacts.mp4

contactAsidClass.toggle('hidden');
}

function toggleSideMenuEvent() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, why not use the same logic as the Calendar module ? Of course and it will be appreciate to refacto the Contact module and like this not do jquery code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in calendar is more simple , there are already a service to toggle Menu . It is not the some case in contact SPA
This is the calendar's function

      $rootScope.$on('toggleSideMenu', function() {
        const sidebarVisibility = calendarSidebarService.getSidebarVisibility();

        calendarSidebarService.setSidebarVisibility(!sidebarVisibility);
      });
    } 

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool so why I not write the same toggle menu service for Contact SPA 👍 to have the same logic in both SPAs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants