Repository navigation
sshutil: remove the unused IsSSHCygwin - #5301
Merged
Merged
Conversation
PathForSSH was its only caller. It switched to cygpathForSSH, which returns the sibling cygpath it needs, and IsSSHCygwin has had no caller since. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
This was referenced Jul 21, 2026
Member
|
Still draft? |
jandubois
marked this pull request as ready for review
July 21, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathForSSHwas its only caller. It switched tocygpathForSSH, which returns the sibling cygpath it needs, andIsSSHCygwinhas had no caller since it landed in #5205.The two assertions dropped from
TestCygpathForSSHre-checked the boolean that thecygpathForSSHassertion on the preceding line already covers, so coverage is unchanged.Part of a series continuing the native Windows OpenSSH work from #5205 and #5270: #5298, #5299, #5300, #5301. They are independent and can merge in any order. #5298 and #5301 both touch
pkg/sshutil/sshutil.go, in different functions, and apply cleanly in either order.