pkg/hostagent: Remove ControlMaster related args from reversesshfs config on Windows
#4082
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
expecting to avoids error like:
|
|
In addition, I think I will make a PR to operate args related to |
norio-nomura
force-pushed
the
remove-control-master-args-from-reversesshfs-config-on-windows
branch
from
9ad821b to
f536261
Compare
|
Updated to rebased on #4093 |
norio-nomura
force-pushed
the
remove-control-master-args-from-reversesshfs-config-on-windows
branch
6 times, most recently
from
21ed649 to
c960e6a
Compare
…config on Windows HostAgent's `sshConfig` already has some ControlMaster related args in `AdditionalArgs`, so it is necessary to remove them to avoid overrides above `Persist=false`. Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
remove-control-master-args-from-reversesshfs-config-on-windows
branch
from
c960e6a to
ddfdc48
Compare
norio-nomura
deleted the
remove-control-master-args-from-reversesshfs-config-on-windows
branch
|
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostAgent's
sshConfigalready has some ControlMaster related args inAdditionalArgs, so it is necessary to remove them to avoid overrides abovePersist=false.