Use SSHAddress for SSH forwarding in QEMU #3254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Sengileyev <[email protected]>
AkihiroSuda
reviewed
Feb 18, 2025
There was a problem hiding this comment.
This line needs to be updated too?
Line 97 in d2fce41
There was a problem hiding this comment.
It will. Eventually. I have this changed in my prototype https://github.com/arixmkii/lima/blob/ffb66c42509c3575d74ca78e562e9085f1ecbd5e/pkg/store/instance.go#L99 But it uses new external dependencies and it is too early to enable this code here. This change is just a refactoring of existing code to make it configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3241
Extending config (effectively data object to pass into driver) with a new field. The field is filled in with the value from Instance. The field is filled only in Start method as it is only used during QEMU machine startup and make no sense in other methods.
Right now it will always be 127.0.0.1 as it is hardcoded during Instance inspect, but in my Windows experiment this value is updated based on WSL2 networking mode (this code still distant from upstream). There is no immediate use for this change, but there is no good reason to have this hardcoded inside driver, when there is already configurable source of truth.