Skip to content

docs: add README zh translation and fix some bad links #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2023
Merged

docs: add README zh translation and fix some bad links #1296

merged 1 commit into from
Jan 14, 2023

Conversation

suyanhanx
Copy link
Contributor

@suyanhanx suyanhanx commented Jan 12, 2023 •
edited
Loading

Signed-off-by: suyanhanx [email protected]

@AkihiroSuda
Copy link
Member

Signed-off-by: han

Could you use your full name, or at least a unique name?

https://github.com/cncf/foundation/blob/main/dco-guidelines.md

The DCO requires the use of a real name that can be used to identify someone in case there is an issue about a contribution they made.

A real name does not require a legal name, nor a birth name, nor any name that appears on an official ID (e.g. a passport). Your real name is the name you convey to people in the community for them to use to identify you as you. The key concern is that your identification is sufficient enough to contact you if an issue were to arise in the future about your contribution.

Your real name should not be an anonymous id or false name that misrepresents who you are.

AkihiroSuda
AkihiroSuda reviewed Jan 13, 2023
View reviewed changes
@AkihiroSuda AkihiroSuda added the documentation Improvements or additions to documentation label Jan 13, 2023
@AkihiroSuda
Copy link
Member

Also please consider squashing commits

@suyanhanx
Copy link
Contributor Author

Also please consider squashing commits

Yes. Before merging, I'll do this.

@suyanhanx suyanhanx force-pushed the readme-trans-zh branch 2 times, most recently from 1b52894 to 9569beb Compare January 13, 2023 02:45
@suyanhanx suyanhanx requested a review from AkihiroSuda January 13, 2023 02:46
@AkihiroSuda
Copy link
Member

Could you update the DCO sign in the git commit message too?
https://github.com/lima-vm/lima/pull/1296/commits

@suyanhanx
Copy link
Contributor Author

Could you update the DCO sign in the git commit message too? https://github.com/lima-vm/lima/pull/1296/commits

Done.

AkihiroSuda
AkihiroSuda approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v0.15 (tentative) milestone Jan 13, 2023
@AkihiroSuda AkihiroSuda merged commit dbe3dbe into lima-vm:master Jan 14, 2023
@suyanhanx suyanhanx deleted the readme-trans-zh branch January 14, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @AkihiroSuda