Skip to content

DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yitzhaktal
Copy link

No description provided.

@yitzhaktal yitzhaktal force-pushed the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch 23 times, most recently from 222dfc3 to d3b55a9 Compare June 1, 2025 09:32
…crets as files via volumes instead of exposing them as environment variables in containers.
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars branch from d3b55a9 to d4efd4d Compare June 1, 2025 09:35
@yitzhaktal yitzhaktal requested review from imeliran and moshiko-s June 1, 2025 09:37
Copy link
Contributor

@imeliran imeliran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

…not-consume-secrets-as-env-vars' of github.com:lightrun-platform/lightrun-k8s-operator into DEVOPS-2694-security-lightrun-installer-container-must-not-consume-secrets-as-env-vars
@yitzhaktal
Copy link
Author

I have tested this again on OpenShift, latest changes are merged. This was tested using this matrix:
Screenshot 2025-06-10 at 1 06 03

@yitzhaktal yitzhaktal requested a review from imeliran June 9, 2025 22:06
Copy link
Contributor

@imeliran imeliran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants