Check Dynamically Cached Module First #913
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Jul 23, 2025
src/runtime/js.zig
Outdated
| .kEvaluated, .kEvaluating => { | ||
| const namespace = new_module.getModuleNamespace(); | ||
| log.info(.js, "dynamic import complete", .{ | ||
| .module = new_module, |
There was a problem hiding this comment.
these two are opaque values, they print meaningless data.
src/runtime/js.zig
Outdated
| _ = resolver.resolve(ctx, namespace); | ||
| return; | ||
| }, | ||
| else => { |
There was a problem hiding this comment.
This is still in the if (cached) block. If the module is cached, why are we loading it again?
src/runtime/js.zig
Outdated
| return; | ||
| }; | ||
| }, | ||
| } |
There was a problem hiding this comment.
Am I following the indentation, wrong, or is this not the end of the if (cached) block, shouldn't there be if not cached handling?
mookums
force-pushed
the
get-cached-dynamic-module-first
branch
from
8deb30f to
bc9f0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just reorders how the dynamic import works. It checks the module cache first and fixes a crash experienced when a module is compiled while it is in the
.kEvaluatingstate.