Skip to content

describeNode #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

describeNode #524

wants to merge 5 commits into from

Conversation

sjorsdonkers
Copy link
Contributor

@sjorsdonkers sjorsdonkers commented Apr 10, 2025

Currently is able return correct data for: #518.

Depends on: lightpanda-io/zig-js-runtime#306

@sjorsdonkers
Copy link
Contributor Author

It appears that the reason why both the browser and puppeteer timeout may be unrelated to the describeNode call.
Even before we call describeNode Puppeteer has already lost the #context.
image
I think we should handle this in a separate PR

@sjorsdonkers sjorsdonkers marked this pull request as ready for review April 11, 2025 12:00
@sjorsdonkers
Copy link
Contributor Author

When determining what should be a node here are some cases to double check in addition to those that have been set to "node".

Set as Node special cases:
Node (itself)
HTMLCollectionIterator (currently handled)
HTMLCollection (currently handled)

Not set as node:
EventTarget
DOMException
DOMImplementation
MutationObserver
MutationRecords
MutationRecord
NamedNodeMap
NodeListIterator
NodeListEntriesIterator
NodeList
ProcessingInstruction
DOMTokenList
Event
U32Iterator
Bottle
URL
URLSearchParams
XMLHttpRequestEventTarget
XMLHttpRequestUpload
XMLHttpRequest
XMLSerializer

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
@sjorsdonkers sjorsdonkers deleted the describeNode branch April 23, 2025 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant