scripts+bw-compatibility-test: update Dave and make it use sqlite #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
bhandras
force-pushed
the
bw-compat-test-sqlite
branch
from
2af6ef1 to
04565d4
Compare
bhandras
force-pushed
the
bw-compat-test-sqlite
branch
from
04565d4 to
4c5f533
Compare
ellemouton
reviewed
Mar 31, 2025
| @@ -45,6 +45,16 @@ wait_for_active_chans bob 2 | |||
| # Show that Bob is now running the current branch. | |||
| do_for print_version bob | |||
|
|
|||
| # Upgrade the compose variables so that the Dave configuration | |||
There was a problem hiding this comment.
i think we should first run the basic tests for bob before updating dave. otherwise we are not testing the send/receive/route with bob on the PR while dave is still on master. So bugs can slip through here in the case where send and receive only work if both nodes have upgraded
There was a problem hiding this comment.
Good point! Changed to run the basic tests after Bob is upgraded as well as after Dave is upgraded (to see that a migration doesn't bork anything).
bhandras
force-pushed
the
bw-compat-test-sqlite
branch
from
4c5f533 to
a427a87
Compare
ellemouton
approved these changes
Apr 1, 2025
| @@ -45,6 +45,16 @@ wait_for_active_chans bob 2 | |||
| # Show that Bob is now running the current branch. | |||
| do_for print_version bob | |||
|
|
|||
| # Upgrade the compose variables so that the Dave configuration | |||
| # upgrade_node shuts down the stable container for a node (currently | ||
| # Bob or Dave), upgrades the compose variables, rebuilds the PR version, | ||
| # and starts it. | ||
| function upgrade_node() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we'll test that a node with SQLite backend (using mixed KV and native schema) remains backward compatible.
It helps prevent incompatibility issues caused by SQL schema changes or invalid migrations, like the one fixed in: #9647.