rpc: update FetchAssetMeta to allow fetch by group key #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `FetchAssetMeta` RPC implementation in `rpcserver.go`. The main function now uses a top-level switch statement that dispatches to dedicated helper functions for handling requests by asset ID, meta hash, and group key. The following helper functions were introduced: - `fetchMetaByAssetID` - `fetchMetaByMetaHash` - `fetchMetaByGroupKey` Each helper encapsulates the logic for fetching and processing asset metadata based on the specific identifier type (including handling both raw byte and hex-encoded string inputs via the main dispatcher). This change improves code organization and readability of the `FetchAssetMeta` method without altering its external behavior. Unit tests in `rpcserver_test.go` have been reviewed and updated to ensure continued coverage of all cases, including new sub-tests for raw byte inputs for each identifier type.
Roasbeef
changed the title
|
Looks like it updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the
FetchAssetMetaRPC implementation inrpcserver.go. The main function now uses a top-level switch statement that dispatches to dedicated helper functions for handling requests by asset ID, meta hash, and group key.The following helper functions were introduced:
fetchMetaByAssetIDfetchMetaByMetaHashfetchMetaByGroupKeyEach helper encapsulates the logic for fetching and processing asset metadata based on the specific identifier type (including handling both raw byte and hex-encoded string inputs via the main dispatcher).
This change improves code organization and readability of the
FetchAssetMetamethod without altering its external behavior.Unit tests in
rpcserver_test.gohave been reviewed and updated to ensure continued coverage of all cases, including new sub-tests for raw byte inputs for each identifier type.Fixes #1504