staticaddr: method to fetch deposits by outpoints #959
Conversation
hieblmi
force-pushed
the
deposit-outpoint
branch
2 times, most recently
from
5f5780d to
1cc4bbb
Compare
hieblmi
force-pushed
the
deposit-outpoint
branch
from
1cc4bbb to
824ea43
Compare
staticaddr/deposit/manager.go
Outdated
| outpoints []string) ([]*Deposit, error) { | ||
|
|
||
| // Check for duplicates. | ||
| duplicates := make(map[string]struct{}) |
There was a problem hiding this comment.
nit: i'd call this existingOutpoints.
|
|
||
| // DepositsForOutpoints returns all deposits that are behind the given | ||
| // outpoints. | ||
| func (m *Manager) DepositsForOutpoints(ctx context.Context, |
There was a problem hiding this comment.
Where would we use the function? Could you please add coverage?
There was a problem hiding this comment.
Yes sure, it is used to restore deposits of a swap after fetching it from the db, see hieblmi@349b930#diff-2c26627ef62d3f06764cb007a83924ef8abb36066a183b4d05e7f42e7c6a7ac9R23-R283
Ideally this would all be handled by GetLoopInByHash, but it isn't currently.
hieblmi
force-pushed
the
deposit-outpoint
branch
from
824ea43 to
bed8b40
Compare
staticaddr/deposit/interface.go
Outdated
| @@ -26,6 +27,10 @@ type Store interface { | |||
| // GetDeposit retrieves a deposit with depositID from the database. | |||
| GetDeposit(ctx context.Context, depositID ID) (*Deposit, error) | |||
|
|
|||
| // DepositForOutpoint retrieves the deposit with the given outpoint. | |||
| DepositForOutpoint(ctx context.Context, txHash chainhash.Hash, | |||
| idx uint32) (*Deposit, error) | |||
There was a problem hiding this comment.
I propose to change the signature to more high level:
DepositForOutpoint(ctx context.Context, outpoint string) (*Deposit, error)
staticaddr/deposit/manager.go
Outdated
| outpoints []string) ([]*Deposit, error) { | ||
|
|
||
| // Check for duplicates. | ||
| duplicates := make(map[string]struct{}) |
There was a problem hiding this comment.
I propose to pre-allocate the map. We now the max size.
| row, err := q.DepositForOutpoint(ctx, params) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| latestUpdate, err := q.GetLatestDepositUpdate( | ||
| ctx, row.DepositID, | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
We can do it with SQL join and avoid making an explicit DB transaction (ExecTx).
hieblmi
force-pushed
the
deposit-outpoint
branch
2 times, most recently
from
78bc133 to
a3531a9
Compare
|
Rebased master |
This PR adds method
DepositsForOutpointsto the deposit manager and required sub-methods to the deposit store.This PR was extracted from and is required by #887 to ease review.