-
Notifications
You must be signed in to change notification settings - Fork 122
easyautoloop: exclude peers #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hieblmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR introduces the ability to exclude specific peers from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful feature to exclude peers from easy autoloop swap attempts. The implementation is well-structured, with changes spanning the CLI, RPC, and core liquidity management logic. The code is clear and follows existing patterns.
I've identified a few areas where performance can be improved by pre-allocating slices and maps. These are minor optimizations but are good practice in Go to avoid unnecessary memory reallocations, especially when dealing with lists that could be large. I've provided specific suggestions for these improvements.
249526d
to
5d840aa
Compare
5d840aa
to
e0bc1fa
Compare
e0bc1fa
to
e0f137c
Compare
e0f137c
to
981eac1
Compare
I think some test coverage would be nice |
0a7e245
to
ea29ace
Compare
Added a unit test. |
This PR adds an option to
parameters.go
to exclude peers from easy autoloop swap attemtps, and also an option to re-enable all peers.--excludeeasypeer
and--includealleasypeers
.Test command:
Result:
Reset all excluded peers to re-enable auto-swapping: