Add watchtower client number of backup metrics #120
Conversation
|
This will have to wait for lightninglabs/lndclient#235 to be merged before the proper |
Jontified
force-pushed
the
add-wt-metrics
branch
2 times, most recently
from
ee6a834 to
59787a0
Compare
There was a problem hiding this comment.
Looks good, thanks for the addition 🗼! Could you make sure to change commit message headers to be consistent with the repo's (just have a look at the past ones). For example Update go.mod and go.sum would become mod: update go.mod and go.sum or Fix comment would be collectors: fix comment (i.e. prefixing with the system/topic it concerns).
We also don't have a long line linter active in this repo, please try to cap lines at 80 chars. Will do a test run after your fixes so that we can merge the lndclient PR and then update the library in here.
Update dependencies affected by this upgrade through go mod tidy
Temporary commit which depends on lndclient fork for testing new features. Remove this commit before merging.
Fix spelling mistake in comment
Jontified
force-pushed
the
add-wt-metrics
branch
from
59787a0 to
e66180e
Compare
|
Things should be up to date now! |
collectors/wt_client_collector.go
Outdated
| numBackups uint32 | ||
| numPendingBackups uint32 |
There was a problem hiding this comment.
that code is not formatted, the linter complains (recommend to set up auto-formatting with go fmt)
There was a problem hiding this comment.
go fmt does not change this for me. Not sure what formatting you'd like here but I indented the uint32 to be on the same indentation.
Jontified
force-pushed
the
add-wt-metrics
branch
from
e66180e to
11d2834
Compare
Add collector for the numBackups and numPendingBackups from the lnd watchtower client API.
Jontified
force-pushed
the
add-wt-metrics
branch
from
11d2834 to
35ffa63
Compare
Summary: This PR adds support for tracking the number of backups that the watchtower client has recorded.
Purpose: We are interested in keeping track of if our watchtower is functioning and making sure that the number of backups corresponds to the number of transactions is one metric we would like to use for this purpose.
Code:
This PR adds a new collector,
wt_client_collector.go, which works very similarly to previous collectors.This PR relies on an updated version of
lndclient(update here) to communicate with the watchtower client interface oflnd.Semantics:
2 metrics are exposed
num_backupsandnum_pending_backups.The metrics will not show up at all if there is no tower active.
Each metric has a towers public key as a label.