Skip to content

linter: enforce some constraints from code guidelines #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2025
Merged

linter: enforce some constraints from code guidelines #238

merged 3 commits into from
Aug 27, 2025

Conversation

bitromortac
Copy link
Contributor

@bitromortac bitromortac mentioned this pull request Aug 25, 2025
Open
3 tasks
bhandras
bhandras approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🎉

@bhandras bhandras requested a review from hieblmi August 26, 2025 14:41
hieblmi
hieblmi approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

In a next step we can update golangci-lint to v2.4.0.

@bitromortac bitromortac merged commit 349456a into lightninglabs:master Aug 27, 2025
1 check passed
@bitromortac
Copy link
Contributor Author

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@hieblmi hieblmi hieblmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitromortac @bhandras @hieblmi