[sql-42] accounts: Update SQL migration to iterate over buckets + ensure proper closure of SQL test stores #1084
+114
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the SQL migration to instead of using the public functions of the BoltStore struct, we instead iterate over the buckets directly. This ensures that the BoltStore struct Acccounts & LastIndexes functions of the BoltStore implementation can be changed, without effecting the SQL migration.
We add a helper function to the functions that creates the test SQL stores, in order to ensure that the store is properly closed when the test is cleaned up.
ViktorTigerstrom
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses review comment #1051 (comment), and changes the implementation of the accounts SQL migration to instead iterate over the Bbolt Buckets, rather than using the public
BoltStorestruct members.Additionally, we add also add a
createStorehelper function for the test SQL db creation methods, that ensures that the SQL db is properly closed during the test cleanup. We will add a similar function for thesessions+firewalldbpackages in their respective PRs, and also build upon that function in the upcoming PR that adds support for thesqldb/v2implementation, which is why that function may feel a bit too verbose for just this PR alone.