Skip to content

Noop HTLC itest fixes #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GeorgeTsagk
Copy link
Member

Description

Modifies some of our existing custom channels itests to now include some manual sats keysends to provide enough liquidity on some nodes to carry out the test case.

Our previous expectation was that asset HTLCs would always pay some sats to the receiver, but now this only happens up to the chan reserve amount.

Based on: lightningnetwork/lnd#9871 , lightninglabs/taproot-assets#1567

@GeorgeTsagk GeorgeTsagk self-assigned this May 28, 2025
@GeorgeTsagk
Copy link
Member Author

GeorgeTsagk commented May 28, 2025

The backwards compatibility itest is expected to fail, as the sender of the HTLCs expects a different commitment view than what the receiver is constructing.

Currently the tapd feature is hidden behind the dev build flag, but we will eventually also support lightninglabs/taproot-assets#1573

@GeorgeTsagk GeorgeTsagk changed the title Noop add itest Noop HTLC itest fixes May 28, 2025
Many of our itest cases would rely on making multiple asset keysends to
initialize the state for our test case. This would include the
expectation that the receiver would receive enough sats to be able to
pay back the sender. With noop HTLCs the sender only sends the sats to
the receiver iff they are currently below reserve. We add some direct
sats keysends to give the receiver some sats balance to be able to
support sending back asset HTLCs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant