Add commit_hash field to GetInfo response
#1034
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorTigerstrom
changed the title
commit_hash field to GetInfo response
| @@ -54,4 +54,7 @@ message GetInfoRequest { | |||
| message GetInfoResponse { | |||
| // The version of the LiTd software that the node is running. | |||
| string version = 1; | |||
|
|
|||
| // The git commit hash of the litd binary. | |||
| string commit_hash = 2; | |||
There was a problem hiding this comment.
Let me know if you think commit would be a more suitable name for this, as the contents may be the tag rather than a commit hash. But opted for this naming as it then mimics the loop getinfo response :)
There was a problem hiding this comment.
Staying consistent is probably better, I would have chosen "revision" I guess.
bitromortac
approved these changes
Apr 15, 2025
| @@ -54,4 +54,7 @@ message GetInfoRequest { | |||
| message GetInfoResponse { | |||
| // The version of the LiTd software that the node is running. | |||
| string version = 1; | |||
|
|
|||
| // The git commit hash of the litd binary. | |||
| string commit_hash = 2; | |||
There was a problem hiding this comment.
Staying consistent is probably better, I would have chosen "revision" I guess.
Comment on lines
+47
to
+50
| // CommitHash returns the commit hash of the current build. | ||
| func CommitHash() string { | ||
| return Commit | ||
| } |
There was a problem hiding this comment.
nit: you could directly use Commit
ellemouton
reviewed
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimics the behaviour of loop pull 914 (lightninglabs/loop#914), but for
litd.This change adds a new field
commit_hashfield to theGetInforesponse, which will include thelitdtagif the currently runninglitddaemon is built on a a clean tag. If thelitdversion is not built on a clean tagged version, this field will instead include the commit hash that the build is based on.The contents of
versionfield of theGetInforesponse is also will also be changed, so that the it'll only include thelitdversion, and not the commit_hash/tag.Note to reviewers:
Just to ensure that this doesn't break the reproducible build across different hosts:
Could you please create a local tag on top of this:
git tag -s v123456789.123456789.123456789-alphamake docker-release tag=v123456789.123456789.123456789-alphaif you're on mac, ormake release tag=v123456789.123456789.123456789-alphawith the correct GO version if you're on Linux.sha256output for the./lightning-terminal-v123456789.123456789.123456789-alpha/manifest-v123456789.123456789.123456789-alpha.txtfile is:e9bc6a43642d7ae679f1f2bd809c3a517cefc0bddb32beee5e990fc60bd75783