Skip to content

Avoid sending stfu for quiescent splice action while pending splice#4426

Merged
wpaulino merged 1 commit intolightningdevkit:mainfrom
wpaulino:no-stfu-send-while-pending-splice
Feb 19, 2026
Merged

Avoid sending stfu for quiescent splice action while pending splice#4426
wpaulino merged 1 commit intolightningdevkit:mainfrom
wpaulino:no-stfu-send-while-pending-splice

Conversation

@wpaulino
Copy link
Contributor

We can't splice while one is already pending, so there's no point in attempting to become quiescent.

Found by the chanmon_consistency fuzzer.

We can't splice while one is already pending, so there's no point in
attempting to become quiescent.
@wpaulino wpaulino added this to the 0.3 milestone Feb 19, 2026
@wpaulino wpaulino requested a review from jkczyz February 19, 2026 00:26
@wpaulino wpaulino self-assigned this Feb 19, 2026
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Feb 19, 2026

👋 Thanks for assigning @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.91%. Comparing base (153e57e) to head (15b04b5).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4426   +/-   ##
=======================================
  Coverage   85.90%   85.91%           
=======================================
  Files         156      156           
  Lines      103965   103972    +7     
  Branches   103965   103972    +7     
=======================================
+ Hits        89316    89326   +10     
  Misses      12128    12128           
+ Partials     2521     2518    -3     
Flag Coverage Δ
tests 85.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@wpaulino
Copy link
Contributor Author

Merging with one approval since this is trivial

@wpaulino wpaulino merged commit 4f8ab7b into lightningdevkit:main Feb 19, 2026
21 of 22 checks passed
@wpaulino wpaulino deleted the no-stfu-send-while-pending-splice branch February 19, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments