Skip to content

[0.2] Clarify splicing feature flag requirements #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tankyleo wants to merge 1 commit into
base: 0.2
Choose a base branch
from
Open

[0.2] Clarify splicing feature flag requirements #4274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
signaling in a future version as testing completes, breaking compatibility.
Support for accepting splices is gated on
`UserConfig::reject_inbound_splices`. Outbound splices can be initiated with
`ChannelManager::splice_channel`.
`ChannelManager::splice_channel`. Initiating a splice requires that the
Copy link
Collaborator

@TheBlueMatt TheBlueMatt Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not really sure about including yet more detail in the release notes here. Its already super long and we don't generally include low-level details here unless missing the details will leave applications broken.

channel counterparty supports splicing. Existing channels can be spliced, as
long as a reconnection with the counterparty occurred after they enabled
splicing. All channel types can be spliced, namely legacy, anchor, and
zero-fee-commitment channels.
* Various APIs have been updated to offer a native Rust async API. All
newly-async traits and structs have a `*Sync` variant which offers the
same API but with sync methods:
Expand Down
7 changes: 7 additions & 0 deletions lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4707,6 +4707,13 @@ where
/// the channel. This will spend the channel's funding transaction output, effectively replacing
/// it with a new one.
///
/// # Required Feature Flags
///
/// Initiating a splice requires that the channel counterparty supports splicing. Existing
/// channels can be spliced, as long as a reconnection with the counterparty occurred after they
Comment on lines +4712 to +4713
Copy link
Collaborator

@TheBlueMatt TheBlueMatt Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Initiating a splice requires that the channel counterparty supports splicing. Existing
/// channels can be spliced, as long as a reconnection with the counterparty occurred after they
/// Initiating a splice requires that the channel counterparty supports splicing. Any
/// channel (no matter the type) can be spliced, as long as a reconnection with the counterparty occurred after they

/// enabled splicing. All channel types can be spliced, namely legacy, anchor, and
/// zero-fee-commitment channels.
Comment on lines +4714 to +4715
Copy link
Collaborator

@TheBlueMatt TheBlueMatt Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this a bit?

Suggested change
/// enabled splicing. All channel types can be spliced, namely legacy, anchor, and
/// zero-fee-commitment channels.
/// enabled splicing.

///
/// # Arguments
///
/// Provide a `contribution` to determine if value is spliced in or out. The splice initiator is
Expand Down