Restore debug assertion removed due to lockorder restrictions #3943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @jkczyz as a reviewer! |
TheBlueMatt
force-pushed
the
2024-09-async-persist-claiming-from-closed-chan
branch
from
6bf3be6 to
d5e20fb
Compare
TheBlueMatt
force-pushed
the
2024-09-async-persist-claiming-from-closed-chan
branch
2 times, most recently
from
4a71e77 to
f2d885a
Compare
In 4582b20 we removed a debug assertion which tested that channels seeing HTLC claim replays on startup would be properly unblocked by later monitor update completion in the downstream chanel. We did so because we couldn't pass our lockorder tests taking a `per_peer_state` read lock to check if a channel was closed while the a `per_peer_state` read lock was already held. However, there's no actual reason for that, its just an arbitrary restriction of our lockorder tests. Here we restore the removed debug assertion by simply enabling the skipping of lockorder checking in `#[cfg(test)]` code - we don't care if there's a theoretical deadlock in test-only code as long as none of our tests actually hit it. Note that we also take this opportunity to enable deadlock detection in `no-std` tests as even `#[cfg(not(feature = "std"))]` test builds allow access to `std`.
TheBlueMatt
force-pushed
the
2024-09-async-persist-claiming-from-closed-chan
branch
from
f2d885a to
eadb70f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
- Coverage 89.05% 89.03% -0.02%
==========================================
Files 167 167
Lines 121800 121847 +47
Branches 121800 121847 +47
==========================================
+ Hits 108464 108482 +18
- Misses 10928 10949 +21
- Partials 2408 2416 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4582b20 we removed a debug assertion which tested that channels seeing HTLC claim replays on startup would be properly unblocked by later monitor update completion in the downstream chanel.
We did so because we couldn't pass our lockorder tests taking a
per_peer_stateread lock to check if a channel was closed while the aper_peer_stateread lock was already held.However, there's no actual reason for that, its just an arbitrary restriction of our lockorder tests.
Here we restore the removed debug assertion by simply enabling the skipping of lockorder checking in
#[cfg(test)]code - we don't care if there's a theoretical deadlock in test-only code as long as none of our tests actually hit it.Note that we also take this opportunity to enable deadlock detection in
no-stdtests as even#[cfg(not(feature = "std"))]test builds allow access tostd.