Remove erroneous debug_assert when handling PaymentForwarded
#665
Conversation
Recent LDK changes made `skimmed_fee_msat` a required field of the LSPS service handler's `payment_forwarded` API, which seemed reasonable given that the field is available since LDK 0.0.122. However, when updating LDK Node we introduced a `debug_assert` that checked the field to be *always* set, which is wrong, as it's only set post-0.0.122 *if* there was some fee skimmed. Here we fix this oversight.
|
I've assigned @joostjager as a reviewer! |
|
Relatedly, we might want to change the API for 0.2 final still, but that's tbd. over at lightningdevkit/rust-lightning#4162 |
| "We expect skimmed_fee_msat to be set since LDK 0.0.122" | ||
| ); | ||
| } | ||
| let skimmed_fee_msat = skimmed_fee_msat.unwrap_or(0); |
There was a problem hiding this comment.
And None can happen when we upgrade while there are still unprocessed events on disk?
There was a problem hiding this comment.
Yes, though they'd need to upgrade directly from an LDK Node version prior to 0.3.0, which shipped June 2024. I don't think we have any users that would still run such an old version, let alone as a forwarding node. And the LSP functionality was ofc. also introduced later than this.
3 participants
Recent LDK changes made
skimmed_fee_msata required field of the LSPS service handler'spayment_forwardedAPI, which seemed reasonable given that the field is available since LDK 0.0.122. However, when updating LDK Node we introduced adebug_assertthat checked the field to be always set, which is wrong, as it's only set post-0.0.122 if there was some fee skimmed. Here we fix this oversight.