Allow pushing some msats on channel open #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-04-push-msat
branch
2 times, most recently
from
f489ed8 to
5022c26
Compare
Collaborator
Author
|
Rebased on main after #13 has been merged. |
jkczyz
reviewed
Apr 21, 2023
src/test/functional_tests.rs
Outdated
| if details.is_empty() || details[0].funding_txo.is_none() { | ||
| std::thread::sleep(Duration::from_secs(1)); | ||
| } else { | ||
| assert_eq!(details[0].inbound_capacity_msat, 39000000); |
Contributor
There was a problem hiding this comment.
Just to refresh my own understanding, why is this not 40000000? A reserve?
Collaborator
Author
There was a problem hiding this comment.
Yes, our current default for the channel reserve is max(1%, 1000sats), which is why we have 1000sats less inbound liquidity here (cf. https://docs.rs/lightning/latest/lightning/util/config/struct.ChannelHandshakeConfig.html#structfield.their_channel_reserve_proportional_millionths).
tnull
force-pushed
the
2023-04-push-msat
branch
2 times, most recently
from
e678b1f to
03bb853
Compare
Collaborator
Author
|
Rebased on main and addressed feedback. |
tnull
force-pushed
the
2023-04-push-msat
branch
from
03bb853 to
98474f3
Compare
Collaborator
Author
|
Squashed without further changes. |
jkczyz
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had so far omitted the
push_msatfield, but it's likely useful, so we add it here.