Expose BIP39 Mnemonic generation in bindings #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already re-export the `bip39` crate to allow users to generate Mnemonics. However, doing the same is not trivial in bindings. Here we expose a simple convenience function that returns a random mnemonic, allowig users to generate them without relying on a third-party library.
tnull
force-pushed
the
2023-05-expose-mnemonic-generation
branch
from
a01b0d6 to
291e9fe
Compare
|
Rebased on main after #88 landed. |
jkczyz
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #88, closes #112We already re-export the
bip39crate to allow users to generate Mnemonics. However, doing the same is not trivial in bindings.Here we expose a simple convenience function that returns a random mnemonic, allowig users to generate them without relying on a third-party library.